[ 
https://issues.apache.org/jira/browse/KNOX-2996?focusedWorklogId=908270&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-908270
 ]

ASF GitHub Bot logged work on KNOX-2996:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Mar/24 09:10
            Start Date: 05/Mar/24 09:10
    Worklog Time Spent: 10m 
      Work Description: upczsh commented on code in PR #829:
URL: https://github.com/apache/knox/pull/829#discussion_r1512424584


##########
gateway-service-definitions/src/main/resources/services/hdfsui/3.0.0/rewrite.xml:
##########
@@ -155,6 +155,9 @@
   <rule dir="OUT" name="HDFSUI/hdfs/outbound/logs/files" pattern="/logs/{**}">
     <rewrite template="{gateway.url}/hdfs/logs/{**}?host={$inboundurl[host]}"/>
   </rule>
+  <rule dir="OUT" name="HDFSUI/hdfs/outbound/topology" pattern="topology">

Review Comment:
   If the URL is similar to http://xxx:port/xxx/topology, you can only use 
pattern="topology" to proxy. If it is http://xxx:port/xxx/topology/xxx, you can 
use pattern="topology/{\*\*}"
   this is my test : 
   use pattern="topology/{\*\*}"
   
![image](https://github.com/apache/knox/assets/50791733/b73a71ad-b14b-49e4-a4ee-e22174599c2d)
   Report an error:
   
![image](https://github.com/apache/knox/assets/50791733/4cab115b-0ee2-4de1-abcf-cce62c72bf8c)
   Therefore, I refer to the current writing method in hdfs rewrite.xml. 
   like this : `  <rule dir="OUT" name="HDFSUI/hdfs/outbound/jmxhtml" 
pattern="jmx">
       <rewrite template="{gateway.url}/hdfs/jmx/?host={$inboundurl[host]}"/>
     </rule>
     <rule dir="OUT" name="HDFSUI/hdfs/outbound/confhtml" pattern="conf">
       <rewrite template="{gateway.url}/hdfs/conf/?host={$inboundurl[host]}"/>
     </rule>
     <rule dir="OUT" name="HDFSUI/hdfs/outbound/stackshtml" pattern="stacks">
       <rewrite template="{gateway.url}/hdfs/stacks/?host={$inboundurl[host]}"/>
     </rule>`





Issue Time Tracking
-------------------

    Worklog Id:     (was: 908270)
    Time Spent: 1h 20m  (was: 1h 10m)

>  Add proxy for hdfs UI network topology
> ---------------------------------------
>
>                 Key: KNOX-2996
>                 URL: https://issues.apache.org/jira/browse/KNOX-2996
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: Release
>    Affects Versions: 2.0.0, 1.6.0
>            Reporter: zhaoshuaihua
>            Priority: Major
>         Attachments: 
> KNOX-2996_-_Add_proxy_for_hdfs_UI_network_topology.patch, 
> image-2023-12-28-16-36-57-726.png, image-2023-12-28-16-37-10-631.png, 
> image-2023-12-28-16-37-15-888.png
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Clicking the hdfs UI network topology proxy failed, the page should be 
> displayed and should not be Error.
> !image-2023-12-28-16-36-57-726.png!!image-2023-12-28-16-37-10-631.png!!image-2023-12-28-16-37-15-888.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to