smolnar82 opened a new pull request, #877:
URL: https://github.com/apache/knox/pull/877

   ## What changes were proposed in this pull request?
   
   Two changes on the `Token Generation UI`:
   - if the `homepage` topology is configured with `Unlimited token lifetime`, 
the lifetime adjustment popup will not shown. The logic was there before, this 
was a casting issue between strings and numbers in the JS code.
   - added an `exclamation` icon to better emphasize the `Unlimited lifetime` 
setting on the UI.
   
   ## How was this patch tested?
   
   Manually tested and confirmed that the popup is no longer displayed when 
creating a 1-year token with `Unlimited lifetime` settings. The new exclamation 
mark is shown as expected (tested with and without the `-1` TTL).
   
   <img width="1747" alt="Screenshot 2024-03-11 at 14 13 13" 
src="https://github.com/apache/knox/assets/34065904/79a33228-617b-4afe-9503-590112b98e83";>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to