[
https://issues.apache.org/jira/browse/KNOX-3018?focusedWorklogId=909245&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909245
]
ASF GitHub Bot logged work on KNOX-3018:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Mar/24 16:28
Start Date: 11/Mar/24 16:28
Worklog Time Spent: 10m
Work Description: smolnar82 opened a new pull request, #878:
URL: https://github.com/apache/knox/pull/878
## What changes were proposed in this pull request?
The `Token Management` and `Token Generation` UIs are updated in a way such
that they display `Never expires` in case a token never expires (that is, if
the token's expiration is set to a negative number).
Moreover, the automated token eviction logic is modified to never remove
those tokens from the underlying token state backend.
## How was this patch tested?
Updated existing unit tests to cover the token eviction logic change and ran
manual testing on the UI.
<img width="1776" alt="Screenshot 2024-03-11 at 16 39 33"
src="https://github.com/apache/knox/assets/34065904/fe510492-25f8-4ab8-993e-2936af93a001";>
<img width="1777" alt="Screenshot 2024-03-11 at 17 14 10"
src="https://github.com/apache/knox/assets/34065904/74304b4f-dce9-42c9-aaea-2b4223f72c41";>
<img width="1781" alt="Screenshot 2024-03-11 at 17 14 41"
src="https://github.com/apache/knox/assets/34065904/db8a6b11-84ba-4c9e-b94e-c8c13f46093d";>
<img width="1778" alt="Screenshot 2024-03-11 at 17 17 46"
src="https://github.com/apache/knox/assets/34065904/af1876ff-d884-4ca1-9bf2-6ab28052cba2";>
Issue Time Tracking
-------------------
Worklog Id: (was: 909245)
Remaining Estimate: 0h
Time Spent: 10m
> Unlimited token generation - Wrong expiration time is shown
> -----------------------------------------------------------
>
> Key: KNOX-3018
> URL: https://issues.apache.org/jira/browse/KNOX-3018
> Project: Apache Knox
> Issue Type: Bug
> Components: TokenGenerationUI
> Affects Versions: 2.0.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 2.1.0
>
> Attachments: Screenshot 2024-03-11 at 14.25.04.png, Screenshot
> 2024-03-11 at 14.25.27.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> *Steps to reproduce*
> * set the {{knox.token.ttl}} to {{-1}} in the {{homepage}} topology for the
> {{KNOXTOKEN}} service
> * set {{knox.token.lifespan.input.enabled = false}} in the {{homepage}}
> topology for the {{KNOXTOKEN}} service
> *Actual results*
> With KNOX-3017 in place, the token is generated, but the expiration is wrong,
> see attached screenshots.
> In addition to this UI bug, the background reaper thread removes this token
> the next time it's triggered. This is also incorrect: unlimited tokens should
> never be removed automatically as they never expire.
> *Expected result*
> Token expiration should indicate an unlimited lifespan and unlimited tokens
> should not be revoked automatically.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
