smolnar82 commented on code in PR #881: URL: https://github.com/apache/knox/pull/881#discussion_r1524697107
########## gateway-spi/src/main/java/org/apache/knox/gateway/services/security/token/TokenMetadata.java: ########## @@ -142,6 +139,32 @@ public Instant getLastUsedAt() { return lastUsedAt == null ? null : Instant.parse(lastUsedAt); } + public void setType(String type) { Review Comment: Ack. ########## gateway-spi/src/main/java/org/apache/knox/gateway/services/security/token/TokenMetadata.java: ########## @@ -32,14 +32,18 @@ import com.fasterxml.jackson.annotation.JsonIgnore; public class TokenMetadata { + public enum Type { + JWT, KNOXSSO_COOKIE, CLIENT_ID + } + public static final String USER_NAME = "userName"; public static final String COMMENT = "comment"; public static final String ENABLED = "enabled"; public static final String PASSCODE = "passcode"; public static final String CREATED_BY = "createdBy"; - public static final String KNOX_SSO_COOKIE = "knoxSSOCookie"; public static final String LAST_USED_AT = "lastUsedAt"; - private static final List<String> KNOWN_MD_NAMES = Arrays.asList(USER_NAME, COMMENT, ENABLED, PASSCODE, CREATED_BY, KNOX_SSO_COOKIE, LAST_USED_AT); + public static final String TYPE = "type"; Review Comment: The enum is TokenMetadata.Type. Let me figure out something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org