[
https://issues.apache.org/jira/browse/KNOX-3024?focusedWorklogId=910898&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-910898
]
ASF GitHub Bot logged work on KNOX-3024:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/24 13:17
Start Date: 21/Mar/24 13:17
Worklog Time Spent: 10m
Work Description: smolnar82 commented on code in PR #891:
URL: https://github.com/apache/knox/pull/891#discussion_r1533888556
##########
gateway-release-common/home/bin/knox-functions.sh:
##########
@@ -50,6 +50,17 @@ DEFAULT_APP_STATUS_TEST_RETRY_SLEEP=2
##### common functions #####
############################
+function setVerbose() {
Review Comment:
KnoxCLI only supports `--verbose`, hence the long version only. Maybe
later...
Issue Time Tracking
-------------------
Worklog Id: (was: 910898)
Time Spent: 40m (was: 0.5h)
> Fix findJava in knox-functions.sh
> ---------------------------------
>
> Key: KNOX-3024
> URL: https://issues.apache.org/jira/browse/KNOX-3024
> Project: Apache Knox
> Issue Type: Bug
> Components: Release
> Affects Versions: 1.4.0, 1.5.0, 2.0.0, 1.6.0, 1.6.1, 1.6.2
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Blocker
> Fix For: 2.1.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> 5 years ago, when I added {{shellcheck}} support to our build in the scope of
> KNOX-1816, I introduced a bug in the {{findJava}} function in
> {{{}knox-functions.sh{}}}: when $JAVA_HOME is not set, and Java is not
> available on the path, the function tries to find java executables under
> {{{}/usr{}}}. However, the current implementation is wrong:
> {noformat}
> $ which java
> /usr/bin/which: no java in
> (/usr/lib64/qt-3.3/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/root/bin)
> $ echo $JAVA_HOME
> $ bin/knoxcli.sh export-cert --type JKS
> Warning: JAVA is not set and could not be found.
> ... {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
