RedYetiDev opened a new pull request, #892:
URL: https://github.com/apache/knox/pull/892
(It is very **important** that you created an Apache Knox JIRA for this
change and that the PR title/commit message includes the Apache Knox JIRA ID!)
> I've requested an account, but do not currently have one. Sorry.
## What changes were proposed in this pull request?
This PR reimplements the `knoxauth.js` file using modern browser features.
Additionally, it changes the jQuery functions back to native JavaScript
functions for speed and complexity reasons, and removes the userAgent
declaration, as it is never used.
## How was this patch tested?
This patch was tested **manually** via each function one at a time.
`get("param") -> 'value' with ?param=value`
`testSameOrigin("https://some.other.site";) -> false with
https://some.safe.site`
`testSameOrigin("https://same.safe.site";) -> true with
https://some.safe.site`
`redirect("https://www.google.com";) -> Redirection successful`
`unicodeBase64Encode("Hello World") -> 'SGVsbG8gV29ybGQ='` (Although
`unescape` and `escape` are deprecated, I left `unescape` in the code)
`keypressed({keyCode:13}) -> login() called`
`login() with admin/password and `?originalUrl=TEST_ORIG_URL -> Redirection
to redirecting.html?originalUrl=TEST_ORIG_URL` *(Initially failure, see commit
e41788498df9c884f0920baa8dbcc4a4c233ff91)
Please review [Knox Contributing
Process](https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process#ContributionProcess-GithubWorkflow)
before opening a pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
