[
https://issues.apache.org/jira/browse/KNOX-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830976#comment-17830976
]
Sandor Molnar commented on KNOX-3025:
-------------------------------------
Hi [~redyetidev] !
First of all, thanks for your contribution to Apache Knox.
Second, could you please elaborate on the above items and explain to us why
your suggested improvements are better than what we have now?
Why is one technic is more efficient than the other? Etc...
Thanks!
> Use newer browser features in knoxauth.js + Removal of used variables
> ---------------------------------------------------------------------
>
> Key: KNOX-3025
> URL: https://issues.apache.org/jira/browse/KNOX-3025
> Project: Apache Knox
> Issue Type: Improvement
> Reporter: Aviv Keller
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The knoxauth.js file currently utilizes outdated and inefficient browser
> features. It could be optimized by leveraging newer, more efficient
> alternatives.
> Details:
> - Rename the 'get' function to 'getQueryParam' and implement it using
> URLSearchParams for clarity and efficiency.
> - Update the 'isSameOrigin' function to utilize URL instead of
> document.create("a") for improved performance.
> - Fully rely on window.location.replace for redirect operations to enhance
> efficiency and reliability.
> - Implement newer techniques in the 'login' function to achieve the desired
> outcome more efficiently.
> - Replace jQuery usage with native features to improve speed and reduce
> complexity in the codebase.
> - And more
> [https://github.com/apache/knox/pull/892/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
