kardolus commented on code in PR #914: URL: https://github.com/apache/knox/pull/914#discussion_r1626259609
########## gateway-server/src/main/java/org/apache/knox/gateway/GatewayServlet.java: ########## @@ -277,4 +278,34 @@ public Enumeration<String> getInitParameterNames() { return config.getInitParameterNames(); } } + + private Exception sanitizeException(Exception e) { + if (e == null || e.getMessage() == null) { + return e; + } + if (!isErrorMessageSanitizationEnabled || e.getMessage() == null) { + return e; + } + String sanitizedMessage = e.getMessage().replaceAll("\\b(?:\\d{1,3}\\.){3}\\d{1,3}\\b", "[hidden]"); Review Comment: Sounds good to me! Should we do this now or in a later iteration? Either is fine by me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org