moresandeep commented on code in PR #917: URL: https://github.com/apache/knox/pull/917#discussion_r1642588449
########## gateway-server/src/main/java/org/apache/knox/gateway/util/KnoxCLI.java: ########## @@ -2570,10 +2570,16 @@ public String getUsage() { private static Properties loadBuildProperties() { Properties properties = new Properties(); - try(InputStream inputStream = KnoxCLI.class.getClassLoader().getResourceAsStream( "build.properties" )) { - properties.load(inputStream); + String BUILD_PROPERTY = "build.properties"; + PrintStream out = System.out; Review Comment: We already have `out` defined on line 142 so we don't have to do it here again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org