[ 
https://issues.apache.org/jira/browse/KNOX-3046?focusedWorklogId=928336&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928336
 ]

ASF GitHub Bot logged work on KNOX-3046:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Aug/24 15:47
            Start Date: 01/Aug/24 15:47
    Worklog Time Spent: 10m 
      Work Description: pzampino commented on code in PR #921:
URL: https://github.com/apache/knox/pull/921#discussion_r1700421971


##########
gateway-service-definitions/src/main/resources/services/yarnui/2.7.0/rewrite.xml:
##########
@@ -23,8 +23,8 @@
      e.g. http://host.com:8088
 -->
 
-<rule dir="IN" name="YARNUI/yarn/inbound/ws" 
pattern="*://*:*/**/yarn/ws/v1/{**}">
-    <rewrite template="{$serviceUrl[YARNUI]}/ws/v1/{**}"/>
+<rule dir="IN" name="YARNUI/yarn/inbound/ws" 
pattern="*://*:*/**/yarn/ws/v1/{**}?{**}">

Review Comment:
   Does this still work WITHOUT any query params?





Issue Time Tracking
-------------------

            Worklog Id:     (was: 928336)
    Remaining Estimate: 50m  (was: 1h)
            Time Spent: 10m

> Yarn RM REST API rewrite should not ignore query parameters
> -----------------------------------------------------------
>
>                 Key: KNOX-3046
>                 URL: https://issues.apache.org/jira/browse/KNOX-3046
>             Project: Apache Knox
>          Issue Type: Improvement
>          Components: Release
>    Affects Versions: 2.0.0, 1.6.0, 2.2.0, 2.1.0
>            Reporter: slankka
>            Priority: Major
>              Labels: gateway, patch-available, pull-request-available
>   Original Estimate: 1h
>          Time Spent: 10m
>  Remaining Estimate: 50m
>
> Knox Gateway rewrite rule should respect YARNUI/ws/v1/cluster/apps
> expected:
>  * /ws/v1/cluster/apps?states=running should return running application.
> actual:
> Knox Gateway returns all.
> Cause:
> It's obvious that rewrite rule do not respect http query parameters.
>  
> [Apache Hadoop 3.4.0 – ResourceManager REST 
> APIs.|https://hadoop.apache.org/docs/current/hadoop-yarn/hadoop-yarn-site/ResourceManagerRest.html#Cluster_Applications_API]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to