[
https://issues.apache.org/jira/browse/KNOX-3054?focusedWorklogId=928690&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928690
]
ASF GitHub Bot logged work on KNOX-3054:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/24 10:10
Start Date: 05/Aug/24 10:10
Worklog Time Spent: 10m
Work Description: hanicz commented on code in PR #928:
URL: https://github.com/apache/knox/pull/928#discussion_r1703882471
##########
gateway-server/src/main/java/org/apache/knox/gateway/GatewayFilter.java:
##########
@@ -203,6 +208,8 @@ public void doFilter( ServletRequest servletRequest,
ServletResponse servletResp
httpResponse.setStatus( HttpServletResponse.SC_NOT_FOUND );
}
+ if("/".equals(requestPath)) this.addCacheHeaders(httpResponse);
Review Comment:
It's possible to be an empty String for null its not possible.
Issue Time Tracking
-------------------
Worklog Id: (was: 928690)
Time Spent: 0.5h (was: 20m)
> Replace ignored meta tag cache headers to HTTP headers
> ------------------------------------------------------
>
> Key: KNOX-3054
> URL: https://issues.apache.org/jira/browse/KNOX-3054
> Project: Apache Knox
> Issue Type: Bug
> Components: Homepage
> Affects Versions: 2.1.0
> Reporter: Tamás Hanicz
> Priority: Minor
> Fix For: 2.1.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Firefox ignores caching headers as meta elements.
> {code:java}
> <meta http-equiv="Cache-Control" content="no-cache, no-store,
> must-revalidate">
> <meta http-equiv="Pragma" content="no-cache">
> <meta http-equiv="Expires" content="0"> {code}
> Due to this Firefox loads index.html from cache and the user won't be
> redirected to the Knox login page when there is no Cookie present and the
> user can't use the homepage.
> The solution is to add the below caching headers to the
> _/gateway/homepage/home/_ endpoint. It serves the index.html to the user.
> {code:java}
> httpResponse.addHeader("Cache-Control", "no-cache, no-store,
> must-revalidate");
> httpResponse.addHeader("Pragma", "no-cache");
> httpResponse.addHeader("Expires", "0"); {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
