slankka commented on code in PR #921:
URL: https://github.com/apache/knox/pull/921#discussion_r1718124840


##########
gateway-service-definitions/src/main/resources/services/yarnui/2.7.0/rewrite.xml:
##########
@@ -23,8 +23,8 @@
      e.g. http://host.com:8088
 -->
 
-<rule dir="IN" name="YARNUI/yarn/inbound/ws" 
pattern="*://*:*/**/yarn/ws/v1/{**}">
-    <rewrite template="{$serviceUrl[YARNUI]}/ws/v1/{**}"/>
+<rule dir="IN" name="YARNUI/yarn/inbound/ws" 
pattern="*://*:*/**/yarn/ws/v1/{**}?{**}">

Review Comment:
   > Does this still work WITHOUT any query params?
   
   yes, without `?{**}`, the query params are ignored



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to