[
https://issues.apache.org/jira/browse/KNOX-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891320#comment-17891320
]
ASF subversion and git services commented on KNOX-3021:
-------------------------------------------------------
Commit 526c4fcf8d3436a3bc8f5dff025f7df9c924c0d7 in knox's branch
refs/heads/dependabot/maven/org.apache.shiro-shiro-core-1.13.0 from Sandor
Molnar
[ https://gitbox.apache.org/repos/asf?p=knox.git;h=526c4fcf8 ]
KNOX-3021 - Http configuration is set on non-SSL Jetty connectors too (#882)
> Http connection properties are not applied when SSL is disabled
> ---------------------------------------------------------------
>
> Key: KNOX-3021
> URL: https://issues.apache.org/jira/browse/KNOX-3021
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 2.0.0, 1.6.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Critical
> Fix For: 2.1.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This is what we have now:
> {noformat}
> HttpConfiguration httpConfig = new HttpConfiguration();
> httpConfig.setRequestHeaderSize(
> config.getHttpServerRequestHeaderBuffer() );
> httpConfig.setResponseHeaderSize(
> config.getHttpServerResponseHeaderBuffer() );
> httpConfig.setOutputBufferSize( config.getHttpServerResponseBuffer() );
> if (config.isSSLEnabled()) {
> HttpConfiguration httpsConfig = new HttpConfiguration( httpConfig );
> ...
> connector = new ServerConnector( server, sslContextFactory, new
> HttpConnectionFactory( httpsConfig ) );
> } else {
> connector = new ServerConnector( server );
> } {noformat}
> When SSL is not enabled, the previously created {{httpConfig}} is not set in
> the created {{ServerConnector}} instance. Therefore, those properties do not
> take effect in those clusters.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
