pzampino commented on PR #948: URL: https://github.com/apache/knox/pull/948#issuecomment-2452268998
> > @hanicz - you may also consider setting the `blockSemicolon` and `blockNonAscii` properties to `false` to match what we have in our [ShiroConfig](https://github.com/apache/knox/blob/master/gateway-provider-security-shiro/src/main/java/org/apache/knox/gateway/deploy/impl/ShiroConfig.java#L37-L39). See #378 and #610 for further information. > > I prefer this suggestion. Can you apply it to this PR? What I meant is that I think we should fix this in the ShiroConfig class, rather than just the test code. We probably should not introduce the additional config properties as part of this PR though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
