[ 
https://issues.apache.org/jira/browse/KNOX-3071?focusedWorklogId=943521&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-943521
 ]

ASF GitHub Bot logged work on KNOX-3071:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Nov/24 11:14
            Start Date: 13/Nov/24 11:14
    Worklog Time Spent: 10m 
      Work Description: hanicz commented on code in PR #940:
URL: https://github.com/apache/knox/pull/940#discussion_r1840059865


##########
gateway-server/src/main/java/org/apache/knox/gateway/util/KnoxCLI.java:
##########
@@ -275,6 +277,12 @@ private int init(String[] args) throws IOException {
           printKnoxShellUsage();
           return -1;
         }
+      } else if (args[i].equals("create-list-aliases")) {

Review Comment:
   It could be the same command. My thinking was that we are introducing two 
new functionalities which in my opinion could warrant a new command.
   
   1. With this change we are able to add multiple aliases to multiple 
topologies. 
   2. When the alias creation is done for a specific topology it will list all 
of the aliases for it.
   





Issue Time Tracking
-------------------

    Worklog Id:     (was: 943521)
    Time Spent: 50m  (was: 40m)

> Batch list-alias and new create-list-aliases KnoxCLI commands
> -------------------------------------------------------------
>
>                 Key: KNOX-3071
>                 URL: https://issues.apache.org/jira/browse/KNOX-3071
>             Project: Apache Knox
>          Issue Type: New Feature
>          Components: KnoxCLI
>    Affects Versions: 2.1.0
>            Reporter: Tamás Hanicz
>            Priority: Minor
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> New feature for list-alias KnoxCLI command. The user should be able to 
> provide multiple clusters concatenated by ':' and list the aliases for all of 
> them. 
> list-alias --cluster cluster1:cluster2:clusterN
> New create-list-aliases command that creates aliases on multiple clusters and 
> list them at the end.
> create-list-aliases --alias alias1 --value value1 --cluster cluster1 --alias 
> alias2 --value value2 --cluster2 --alias aliasN --value valueN --cluster 
> clusterN
> When there is a --cluster args every alias before it will be added to that 
> cluster.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to