hanicz commented on code in PR #940:
URL: https://github.com/apache/knox/pull/940#discussion_r1840059865


##########
gateway-server/src/main/java/org/apache/knox/gateway/util/KnoxCLI.java:
##########
@@ -275,6 +277,12 @@ private int init(String[] args) throws IOException {
           printKnoxShellUsage();
           return -1;
         }
+      } else if (args[i].equals("create-list-aliases")) {

Review Comment:
   It could be the same command. My thinking was that we are introducing two 
new functionalities which in my opinion could warrant a new command.
   
   1. With this change we are able to add multiple aliases to multiple 
topologies. 
   2. When the alias creation is done for a specific topology it will list all 
of the aliases for it.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to