moresandeep commented on code in PR #972:
URL: https://github.com/apache/knox/pull/972#discussion_r1884187593
##########
gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/filter/Pac4jDispatcherFilter.java:
##########
@@ -122,6 +122,12 @@ public class Pac4jDispatcherFilter implements Filter,
SessionInvalidator {
private static final String PAC4J_OIDC_TYPE = "oidc.type";
+ /* property for specifying pac4j cookies ttl */
+ public static final String PAC4J_COOKIE_MAX_AGE = "pac4j.cookie.max.age";
+
+ /* default value is same is KNOXSSO token ttl default */
+ public static final int PAC4J_COOKIE_MAX_AGE_DEFAULT = -1;
Review Comment:
@smolnar82 actually `PAC4J_COOKIE_MAX_AGE` is used outside of this class in
`KnoxSessionStore` which needs this to be public.
I did update the `int` to `String` thanks for pointing it out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
