smolnar82 commented on code in PR #981:
URL: https://github.com/apache/knox/pull/981#discussion_r1923926079
##########
gateway-service-metadata/src/main/java/org/apache/knox/gateway/service/metadata/KnoxMetadataResource.java:
##########
@@ -169,32 +164,31 @@ private Response
generateFailureFileDownloadResponse(Status status, String error
return responseBuilder.build();
}
- private Certificate getPublicCertificate(GatewayServices gatewayServices,
GatewayConfig config) {
+ private Certificate[] getPublicCertificates() {
try {
- final KeystoreService keystoreService =
gatewayServices.getService(ServiceType.KEYSTORE_SERVICE);
- return
keystoreService.getKeystoreForGateway().getCertificate(config.getIdentityKeyAlias());
- } catch (KeyStoreException | KeystoreServiceException e) {
+ return
X509CertificateUtil.fetchPublicCertsFromServer(request.getRequestURL().toString(),
true, null);
Review Comment:
This is why the build is failing:
```
2025-01-15T21:06:09.1903508Z [ERROR] COMPILATION ERROR :
2025-01-15T21:06:09.1908060Z [INFO]
-------------------------------------------------------------
2025-01-15T21:06:09.1913374Z [ERROR]
/home/runner/work/knox/knox/gateway-service-metadata/src/main/java/org/apache/knox/gateway/service/metadata/KnoxMetadataResource.java:[169,33]
cannot find symbol
2025-01-15T21:06:09.1919329Z symbol: method
fetchPublicCertsFromServer(java.lang.String,boolean,<nulltype>)
2025-01-15T21:06:09.1920613Z location: class
org.apache.knox.gateway.util.X509CertificateUtil
2025-01-15T21:06:09.1922183Z [ERROR]
/home/runner/work/knox/knox/gateway-service-metadata/src/main/java/org/apache/knox/gateway/service/metadata/KnoxMetadataResource.java:[180,28]
cannot find symbol
2025-01-15T21:06:09.1938355Z symbol: method
writeCertificatesToFile(java.security.cert.Certificate[],java.io.File)
2025-01-15T21:06:09.1939307Z location: class
org.apache.knox.gateway.util.X509CertificateUtil
2025-01-15T21:06:09.1939866Z [INFO] 2 errors
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
