vinayakphegde commented on PR #989:
URL: https://github.com/apache/knox/pull/989#issuecomment-2664839633
> I did notice that the rewrite rule for 2.5.10 differs from the 2.1.0
addition in this PR. Is that intentional?
Hmm, correct. `?host={$inboundurl[host]}?port={$inboundurl[port]}?{**}` is
additional in the rewrite template here.
In general, we have this same difference between 2.1.0 and 2.5.10 UI rules.
for example
2.1.0:
[hbaseui/2.1.0/rewrite.xml#L129-#L146](https://github.com/apache/knox/blob/master/gateway-service-definitions/src/main/resources/services/hbaseui/2.1.0/rewrite.xml#L129-#L146)
2.5.10:
[hbaseui/2.5.10/rewrite.xml#L152-#L178](https://github.com/apache/knox/blob/master/gateway-service-definitions/src/main/resources/services/hbaseui/2.5.10/rewrite.xml#L152-#L178)
Are these parameters no longer needed in the latest versions? If so, what
was the reason for this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
