smolnar82 commented on PR #991: URL: https://github.com/apache/knox/pull/991#issuecomment-2665505221
My two cents: - the description suggest tests in the `KNOXSSOUT` service but those tests are added in the test cases for `KNOXSSO` ([WebSSOutResourceTest ](https://github.com/apache/knox/blob/master/gateway-service-knoxssout/src/test/java/org/apache/knox/gateway/service/knoxsso/WebSSOutResourceTest.java) vs [WebSSOResourceTest](https://github.com/apache/knox/blob/master/gateway-service-knoxsso/src/test/java/org/apache/knox/gateway/service/knoxsso/WebSSOResourceTest.java)) - these tests - within `WebSSOResourceTest` - are actually testing [`RegexUtils`](https://github.com/apache/knox/blob/de3c78cbc44098d273f520b0510cad9519843849/gateway-util-common/src/main/java/org/apache/knox/gateway/util/RegExUtils.java). I wonder if it was better to have those test cases in a new `RegExUtilsTest` class :bulb: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
