[
https://issues.apache.org/jira/browse/KNOX-3097?focusedWorklogId=957539&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-957539
]
ASF GitHub Bot logged work on KNOX-3097:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Feb/25 14:57
Start Date: 18/Feb/25 14:57
Worklog Time Spent: 10m
Work Description: moresandeep commented on PR #991:
URL: https://github.com/apache/knox/pull/991#issuecomment-2665959520
> My two cents:
>
> * the description suggest tests in the `KNOXSSOUT` service but those tests
are added in the test cases for `KNOXSSO` ([WebSSOutResourceTest
](https://github.com/apache/knox/blob/master/gateway-service-knoxssout/src/test/java/org/apache/knox/gateway/service/knoxsso/WebSSOutResourceTest.java)
vs
[WebSSOResourceTest](https://github.com/apache/knox/blob/master/gateway-service-knoxsso/src/test/java/org/apache/knox/gateway/service/knoxsso/WebSSOResourceTest.java))
> * these tests - within `WebSSOResourceTest` - are actually testing
[`RegexUtils`](https://github.com/apache/knox/blob/de3c78cbc44098d273f520b0510cad9519843849/gateway-util-common/src/main/java/org/apache/knox/gateway/util/RegExUtils.java).
I wonder if it was better to have those test cases in a new `RegExUtilsTest`
class 💡
I think so too, i don't see a test for RegexUtils class, so perhaps create a
new one and add these tests to it?
Issue Time Tracking
-------------------
Worklog Id: (was: 957539)
Time Spent: 1h (was: 50m)
> Add more redirect.whitelist Test Cases for KNOXSSOUT
> ----------------------------------------------------
>
> Key: KNOX-3097
> URL: https://issues.apache.org/jira/browse/KNOX-3097
> Project: Apache Knox
> Issue Type: Improvement
> Components: Tests
> Reporter: Larry McCay
> Assignee: Larry McCay
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Adding more test cases to incorporate lookahead assertions to check for
> unwanted characters in URLs to be used in a redirect.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
