[
https://issues.apache.org/jira/browse/KNOX-3105?focusedWorklogId=959898&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-959898
]
ASF GitHub Bot logged work on KNOX-3105:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Mar/25 07:49
Start Date: 04/Mar/25 07:49
Worklog Time Spent: 10m
Work Description: smolnar82 commented on code in PR #1001:
URL: https://github.com/apache/knox/pull/1001#discussion_r1978693819
##########
gateway-provider-security-authc-remote/src/main/java/org/apache/knox/gateway/filter/RemoteAuthFilter.java:
##########
@@ -203,12 +217,20 @@ private HttpURLConnection
getHttpURLConnection(ServletContext servletContext) th
KeystoreService keystoreService =
services.getService(ServiceType.KEYSTORE_SERVICE);
if (keystoreService != null) {
try {
- truststore = keystoreService.getTruststoreForHttpClient();
+ // Try topology-specific truststore first if configured
Review Comment:
Given the updated logic, `getTrustStore()` should be a separate private
method.
Issue Time Tracking
-------------------
Worklog Id: (was: 959898)
Time Spent: 0.5h (was: 20m)
> Add Topology Level Config for Truststore to RemoteAuthProvider
> --------------------------------------------------------------
>
> Key: KNOX-3105
> URL: https://issues.apache.org/jira/browse/KNOX-3105
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Reporter: Larry McCay
> Assignee: Larry McCay
> Priority: Major
> Fix For: 2.2.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> I originally had this topology level config only for the truststore and
> password but decided that it should be configured at the gateway level.
> However, it is much easier to use specific truststores for dev and testing
> environments than adding a cert from one Knox to another's truststore which
> may have other certs, etc.
> This change will add the params for location and password with alias service
> support of the password.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
