lmccay opened a new pull request, #1016: URL: https://github.com/apache/knox/pull/1016
Provide appropriate defaults for CLIENTID extension of KNOXTOKEN API ## What changes were proposed in this pull request? There are a number of params that should be set by default for the CLIENTID extension of the KNOXTOKEN API. This will reduce the likelihood of errors based on having to explicitly configure these params which are either required or the logical defaults. 1. knox.token.exp.server-managed should be enabled by default this service if based on passcode tokens and requires server state 2. knox.token.ttl - should be -1 by default to not expire - fight me! 3. knox.token.hash.key should be set by default as well. We need to check whether this already exists via the AliasService and if not we should generate it automatically or fail to deploy with appropriate error/exception. This required the creation of a hook into the KNOXTOKEN resource to allow extensions to wrap the servletContext in order to provide defaults appropriate to the extension that would otherwise require the deploying admin to configure the same properties as convention for every deployment. ## How was this patch tested? New unit tests added and existing tests run. Manually tested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
