smolnar82 commented on PR #1010: URL: https://github.com/apache/knox/pull/1010#issuecomment-2782485017
I gave the new version a quick review, and it looks good to me. I'd like to as @pzampino and @moresandeep to review the code again. I'd also like to ask you, @hanicz, to elaborate on your manual testing in the PR description. Since your changes now have an effect on the 'usual' HA dispatch too, I'd be interested to see one (or more) service(s) testing from the HA perspective. It's perfectly enough to indicate you tested XYZ service with its HA-dispatch configured and failover/retry happened as expected. I'd just like to see some proof we did that before merging this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
