[jira] [Work logged] (KNOX-3148) Make pac4j session cookie SameSite attribute configurable

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/KNOX-3148?focusedWorklogId=969122&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-969122
 ]

ASF GitHub Bot logged work on KNOX-3148:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/May/25 09:07
            Start Date: 09/May/25 09:07
    Worklog Time Spent: 10m 
      Work Description: smolnar82 commented on PR #1042:
URL: https://github.com/apache/knox/pull/1042#issuecomment-2865777411

   Thanks, @hanicz, for your contribution. It was a good call to build the 
Set-Cookie header and add all values. Since you are doing that, I think there 
is an opportunity to improve the code.
   
   See the same (similar) code fragment in `WebSSOResource`:
   
![image](https://github.com/user-attachments/assets/ebd46c93-81df-4f9e-ab67-ba913588a878)
   I think it'd be beneficial to create a utility class that builds the 
`Set-Cookie` header, where all the params can be constants, the utility class 
can be tested, etc... Then resource, filter classes can use that class and its 
method(s).
   What do you think?




Issue Time Tracking
-------------------

    Worklog Id:     (was: 969122)
    Time Spent: 20m  (was: 10m)

> Make pac4j session cookie SameSite attribute configurable
> ---------------------------------------------------------
>
>                 Key: KNOX-3148
>                 URL: https://issues.apache.org/jira/browse/KNOX-3148
>             Project: Apache Knox
>          Issue Type: Improvement
>          Components: Server
>    Affects Versions: 2.2.0
>            Reporter: Tamás Hanicz
>            Assignee: Tamás Hanicz
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Make pac4j session cookie SameSite attribute configurable. Currently it is 
> set to None.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)