moresandeep commented on PR #1043: URL: https://github.com/apache/knox/pull/1043#issuecomment-2907884343
> @moresandeep - why add a new provider for this and not just add it to common so that it is available everywhere that extends that? Good point, I thought about that but decided against it in favor of code separation. Since all of the implementations use Common any bug might affect all the providers. Not all providers need this the ones that need this feature are virtual groups (already included in default) and hadoop-group-lookup so i decided to create a new provider that supports these. Putting this in common will be easy but this is not really common feature that can be used by all the other providers. Do you anticipate this to be used by others? i can move this common in that case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
