moresandeep commented on PR #1043: URL: https://github.com/apache/knox/pull/1043#issuecomment-2963943512
@pzampino i addressed your comments, following are the changes in a nutshell: 1. Regex expressions are now constants 2. For cases where proxy user impersonation fails proxy group proxy impersonation will be evaluated 3. Added unit tests for the item no. 2 I tested it locally and verified that it works. Let me know if there are more changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org