[
https://issues.apache.org/jira/browse/KNOX-3177?focusedWorklogId=977611&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-977611
]
ASF GitHub Bot logged work on KNOX-3177:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/25 07:58
Start Date: 05/Aug/25 07:58
Worklog Time Spent: 10m
Work Description: hanicz opened a new pull request, #1072:
URL: https://github.com/apache/knox/pull/1072
## What changes were proposed in this pull request?
This XML validation is aiming to avoid cases like
https://github.com/apache/knox/pull/1034 where a service definition were merged
with an incorrect XML format. The build should fail in these cases.
## How was this patch tested?
Ran mvn verify on correct and incorrect XMLs
```
[ERROR] Failed to execute goal
org.codehaus.mojo:xml-maven-plugin:1.1.0:validate (default) on project
gateway-service-definitions: While parsing
/Users/thanicz/dev/public/knox/gateway-service-definitions/src/main/resources/services/pinot/1.3.0/rewrite.xml,
at
file:/Users/thanicz/dev/public/knox/gateway-service-definitions/src/main/resources/services/pinot/1.3.0/rewrite.xml,
line 23, column 7: fatal error: The element type "rewrite" must be terminated
by the matching end-tag "</rewrite>".
[ERROR] While parsing
/Users/thanicz/dev/public/knox/gateway-service-definitions/src/main/resources/services/pinot/1.3.0/rewrite.xml,
at
file:/Users/thanicz/dev/public/knox/gateway-service-definitions/src/main/resources/services/pinot/1.3.0/rewrite.xml,
line 23, column 7: fatal error: The element type "rewrite" must be terminated
by the matching end-tag "</rewrite>".
```
Issue Time Tracking
-------------------
Worklog Id: (was: 977611)
Remaining Estimate: 0h
Time Spent: 10m
> Service definitions XML validation during build time
> ----------------------------------------------------
>
> Key: KNOX-3177
> URL: https://issues.apache.org/jira/browse/KNOX-3177
> Project: Apache Knox
> Issue Type: Improvement
> Components: Build
> Affects Versions: 2.1.0
> Reporter: Tamás Hanicz
> Assignee: Tamás Hanicz
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This XML validation is aiming to avoid cases like
> https://github.com/apache/knox/pull/1034 where a service definition were
> merged with an incorrect XML format. The build should fail in these cases.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
