[
https://issues.apache.org/jira/browse/KNOX-3185?focusedWorklogId=981664&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-981664
]
ASF GitHub Bot logged work on KNOX-3185:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Sep/25 16:35
Start Date: 03/Sep/25 16:35
Worklog Time Spent: 10m
Work Description: pzampino commented on code in PR #1080:
URL: https://github.com/apache/knox/pull/1080#discussion_r2319516233
##########
gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java:
##########
@@ -300,6 +301,16 @@ public void init() throws AliasServiceException,
ServiceLifecycleException, KeyL
tokenMAC = new TokenMAC(gatewayConfig.getKnoxTokenHashAlgorithm(),
aliasService.getPasswordFromAliasForGateway(TokenMAC.KNOX_TOKEN_HASH_KEY_ALIAS_NAME));
tokenLimitPerUser = gatewayConfig.getMaximumNumberOfTokensPerUser();
Review Comment:
Typically, topology-level config overrides gateway-level config. This
appears to be the opposite.
Issue Time Tracking
-------------------
Worklog Id: (was: 981664)
Time Spent: 20m (was: 10m)
> Make token limit configurable on the topology level
> ---------------------------------------------------
>
> Key: KNOX-3185
> URL: https://issues.apache.org/jira/browse/KNOX-3185
> Project: Apache Knox
> Issue Type: Task
> Components: Server
> Affects Versions: 2.0.0, 1.6.0, 2.1.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 3.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As of now, the {{gateway.knox.token.limit.per.user}} config (added in
> KNOX-2627) exists only on the gateway-level. There is a need for being set
> that limit on the topology level too. That is, the gateway-level config
> should be overridden by the topology-level config (as we support this path in
> many other configs too).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
