smolnar82 commented on code in PR #1082:
URL: https://github.com/apache/knox/pull/1082#discussion_r2333501015
##########
knox-token-generation-ui/token-generation/app/token-generation.service.ts:
##########
@@ -73,14 +75,31 @@ export class TokenGenService {
});
}
+ isTokenHashKeyPresent(): Promise<boolean> {
+ let headers = new HttpHeaders();
+ headers = this.addHeaders(headers);
+ return this.http.get(this.metadataInfoUrl, { headers: headers})
+ .toPromise()
+ .then(response => {
+ return response['generalProxyInfo']?.['enableTokenManagement']
=== 'true';
+ })
+ .catch((err: HttpErrorResponse) => {
+ console.debug('TokenGenService --> isTokenHashKeyPresent() -->
' + this.metadataInfoUrl + '\n error: ' + err.message);
Review Comment:
IMO, those debug messages are quite useful in case there are errors. Thus,
I'd rather keep them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
