[
https://issues.apache.org/jira/browse/KNOX-3035?focusedWorklogId=988166&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-988166
]
ASF GitHub Bot logged work on KNOX-3035:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Oct/25 11:57
Start Date: 21/Oct/25 11:57
Worklog Time Spent: 10m
Work Description: hanicz commented on code in PR #1101:
URL: https://github.com/apache/knox/pull/1101#discussion_r2447877367
##########
gateway-spi/src/main/java/org/apache/knox/gateway/util/GroupUtils.java:
##########
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.knox.gateway.util;
+
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+
+public class GroupUtils {
+
+ public static List<String> getGroupStrings(Collection<String> groupNames,
final int lengthLimit, final int sizeLimitBytes) {
+ if (groupNames.isEmpty()) {
+ return Collections.emptyList();
+ }
+
+ if (sizeLimitBytes > 0) {
+ return getGroupStringsBySize(groupNames, sizeLimitBytes);
+ } else {
+ return getGroupStringsByLength(groupNames, lengthLimit);
+ }
+ }
+
+ private static List<String> getGroupStringsBySize(Collection<String>
groupNames, int sizeLimitBytes) {
+ final List<String> groupStrings = new ArrayList<>();
+ StringBuilder sb = new StringBuilder();
+ int currentSize = 0; // UTF-8 byte count
+
+ for (String groupName : groupNames) {
+ int commaBytes = sb.length() > 0 ? 1 : 0; // comma between groups
+ int groupBytes = groupName.getBytes(StandardCharsets.UTF_8).length;
+ int projectedSize = currentSize + commaBytes + groupBytes;
+
+ if (projectedSize > sizeLimitBytes) {
+ groupStrings.add(sb.toString());
+ sb = new StringBuilder();
+ currentSize = 0;
+ }
+
+ currentSize = addCommaIfNeeded(sb, currentSize);
+ sb.append(groupName);
+ currentSize += groupBytes;
+ }
+
+ if (sb.length() > 0) {
+ groupStrings.add(sb.toString());
Review Comment:
What happens if the size limit is smaller than a specific group(s).? Does
the logic send one or multiple empty headers and one very long one? I can't
find any exception handling or test for this. This scenario is a user error but
might be useful to handle it.
Otherwise looks good.
Issue Time Tracking
-------------------
Worklog Id: (was: 988166)
Time Spent: 0.5h (was: 20m)
> Group header value should be based on data size and not number
> --------------------------------------------------------------
>
> Key: KNOX-3035
> URL: https://issues.apache.org/jira/browse/KNOX-3035
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Reporter: Sandeep More
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 3.0.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> KNOX-2974 and KNOX-3023 support adding group headers to requests flowing to
> downstream endpoints. Currently the groups headers is based on number of
> groups (1000 default). A lot of webservers and loadbalancers support header
> sizes between 4KB - 8KB which be an issue when header sizes are large.
> This JIRA is to update this logic to limit groups in one header to configured
> size in KBs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
