smolnar82 commented on code in PR #1101: URL: https://github.com/apache/knox/pull/1101#discussion_r2450877717
########## gateway-spi/src/main/java/org/apache/knox/gateway/util/GroupUtils.java: ########## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.knox.gateway.util; + +import java.nio.charset.StandardCharsets; +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.List; + +public class GroupUtils { + + public static List<String> getGroupStrings(Collection<String> groupNames, final int lengthLimit, final int sizeLimitBytes) { + if (groupNames.isEmpty()) { + return Collections.emptyList(); + } + + if (sizeLimitBytes > 0) { + return getGroupStringsBySize(groupNames, sizeLimitBytes); + } else { + return getGroupStringsByLength(groupNames, lengthLimit); + } + } + + private static List<String> getGroupStringsBySize(Collection<String> groupNames, int sizeLimitBytes) { + final List<String> groupStrings = new ArrayList<>(); + StringBuilder sb = new StringBuilder(); Review Comment: I updated the code as follows: - to ensure the safety of the input `groupNames`, a defensive copy is created which I use down the line when processing the input - new unit test to cover the multi-threaded usage of this new utility method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
