smolnar82 opened a new pull request, #1102: URL: https://github.com/apache/knox/pull/1102
[KNOX-3210](https://issues.apache.org/jira/browse/KNOX-3210) - user-auth-test KnoxCLI command isn't working on JDK17 ## What changes were proposed in this pull request? Instead of declaring JDK17 specific JVM properties in different locations, I created a dedicated function (called `addJdk17Properties`) and ensured it's invoked wherever it's necessary. All these logic is removed from any other places now. The new function uses the broader set of configs which we previously had in `knox-functions.sh`, so that it will work in `knoxcli.sh` too. ## How was this patch tested? Tested in a rela cluster: - restarted Knox successfully - ran the `user-auth-test` KnoxCLI command: ``` $ bin/knoxcli.sh user-auth-test --cluster webhdfs_descriptor --u sam --p sam-password --g Java version is 17. Adding properties to enable Knox to run on JDK 17 LDAP authentication successful! sam is a member of: scientist sam is a member of: analyst ``` I added some dummy `-Dtest=smolnar` JCM arguments too in the new function and printed the generated `APP_JAVA_OPTS` to see if all scripts capture the new values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
