[ 
https://issues.apache.org/jira/browse/KNOX-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sandor Molnar updated KNOX-3223:
--------------------------------
    Description: 
Last week the team switched to JDK 17 with a giant change in [PR 
1114|https://github.com/apache/knox/pull/1114]. During code reviews we found 
that there are many "suppress" annotations ({{{}@SuppressForbidden{}}} and 
{{{}@SuppressWarnings("PMD"){}}}) were added as well as exclusions and 
ignoredNonTestScopedDependencies for static code analyzer tools.

We should review them and make a decision if they are ok or fix the root cause 
and enable them.

  was:
Last week the team switched to JDK 17 with a giant change in PR 1104. During 
code reviews we found that there are many "suppress" annotations 
({{{}@SuppressForbidden{}}} and {{{}@SuppressWarnings("PMD"){}}}) were added as 
well as exclusions and ignoredNonTestScopedDependencies for static code 
analyzer tools.

We should review them and make a decision if they are ok or fix the root cause 
and enable them.


> Review exclusions from PR 1114
> ------------------------------
>
>                 Key: KNOX-3223
>                 URL: https://issues.apache.org/jira/browse/KNOX-3223
>             Project: Apache Knox
>          Issue Type: Task
>          Components: Server
>    Affects Versions: 3.0.0
>            Reporter: Sandor Molnar
>            Assignee: Sandor Molnar
>            Priority: Major
>             Fix For: 3.0.0
>
>
> Last week the team switched to JDK 17 with a giant change in [PR 
> 1114|https://github.com/apache/knox/pull/1114]. During code reviews we found 
> that there are many "suppress" annotations ({{{}@SuppressForbidden{}}} and 
> {{{}@SuppressWarnings("PMD"){}}}) were added as well as exclusions and 
> ignoredNonTestScopedDependencies for static code analyzer tools.
> We should review them and make a decision if they are ok or fix the root 
> cause and enable them.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to