smolnar82 commented on code in PR #1116: URL: https://github.com/apache/knox/pull/1116#discussion_r2584904063
########## .github/workflows/build/gateway-site.xml: ########## @@ -0,0 +1,197 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + +http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +--> +<configuration> + + <property> + <name>gateway.service.alias.impl</name> + <value>org.apache.knox.gateway.services.security.impl.RemoteAliasService</value> + </property> + <property> + <name>gateway.port</name> + <value>8443</value> + <description>The HTTP port for the Gateway.</description> + </property> + + <property> + <name>gateway.path</name> + <value>gateway</value> + <description>The default context path for the gateway.</description> + </property> + + <property> + <name>gateway.gateway.conf.dir</name> + <value>deployments</value> + <description>The directory within GATEWAY_HOME that contains gateway topology files and deployments.</description> + </property> + + <property> + <name>gateway.hadoop.kerberos.secured</name> + <value>false</value> + <description>Boolean flag indicating whether the Hadoop cluster protected by Gateway is secured with Kerberos</description> + </property> + + <property> + <name>java.security.krb5.conf</name> + <value>/etc/knox/conf/krb5.conf</value> + <description>Absolute path to krb5.conf file</description> + </property> + + <property> + <name>java.security.auth.login.config</name> + <value>/etc/knox/conf/krb5JAASLogin.conf</value> + <description>Absolute path to JAAS login config file</description> + </property> + + <property> + <name>sun.security.krb5.debug</name> + <value>false</value> + <description>Boolean flag indicating whether to enable debug messages for krb5 authentication</description> + </property> + + <!-- @since 0.10 Websocket configs --> + <property> + <name>gateway.websocket.feature.enabled</name> + <value>true</value> + <description>Enable/Disable websocket feature.</description> + </property> + + <property> + <name>gateway.scope.cookies.feature.enabled</name> + <value>false</value> + <description>Enable/Disable cookie scoping feature.</description> + </property> + + <property> + <name>gateway.cluster.config.monitor.ambari.enabled</name> + <value>false</value> + <description>Enable/disable Ambari cluster configuration monitoring.</description> + </property> + + <property> + <name>gateway.cluster.config.monitor.ambari.interval</name> + <value>60</value> + <description>The interval (in seconds) for polling Ambari for cluster configuration changes.</description> + </property> + <!-- @since 2.0.0 WebShell configs --> + <!-- must have websocket enabled to use webshell --> + <property> + <name>gateway.webshell.feature.enabled</name> + <value>true</value> + <description>Enable/Disable webshell feature.</description> + </property> + <property> + <name>gateway.webshell.max.concurrent.sessions</name> + <value>20</value> + <description>Maximum number of total concurrent webshell sessions</description> + </property> + <property> + <name>gateway.webshell.audit.logging.enabled</name> + <value>false</value> + <description>[Experimental Feature] Enable/Disable webshell command audit logging. + NOTE: Turning this on might log secrets that might be part of + command line arguments, please consider this before turning this on.</description> + </property> Review Comment: Remove this one as it defaults to `false` anyway. ########## .github/workflows/build/conf/topologies/knoxtoken.xml: ########## @@ -0,0 +1,56 @@ +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + +http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +--> +<topology> + <gateway> + <provider> + <role>federation</role> + <name>JWTProvider</name> + <enabled>true</enabled> + <param> + <name>knox.token.use.cookie</name> + <value>false</value> + </param> + <param> + <name>jwt.expected.sigalg</name> + <value>RS256</value> + </param> + </provider> + </gateway> + <service> + <role>KNOXTOKEN</role> + <param> + <name>knoxsso.token.ttl</name> + <value>86400000</value> + </param> + </service> + <service> + <role>KNOX-AUTH-SERVICE</role> + <param> + <name>preauth.auth.header.actor.id.name</name> + <value>x-knox-actor-username</value> + </param> + <param> + <name>preauth.auth.header.actor.groups.prefix</name> + <value>x-knox-actor-groups</value> + </param> + <param> + <name>preauth.group.filter.pattern</name> + <value>[^\s]+</value> + </param> + </service> +</topology> Review Comment: It was hard to read this topology, can you please apply the appropriate level of indentation? Moreover, I'm not sure I understand the reason why this topology is added. It's not used anywhere... ########## .github/workflows/build/gateway.sh: ########## @@ -0,0 +1,22 @@ +#!/bin/sh +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to you under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Move the KnoxShell directory to proper place +# This is vecause of https://github.com/docker/compose/issues/4581#issuecomment-321386605 Review Comment: nit: typo in `vecause` (-> `because`) ########## .github/workflows/build/gateway-site.xml: ########## @@ -0,0 +1,197 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + +http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +--> +<configuration> + + <property> + <name>gateway.service.alias.impl</name> + <value>org.apache.knox.gateway.services.security.impl.RemoteAliasService</value> Review Comment: I'd use `DefaultAliasService`, as no remote alias service provider is configured. ########## .github/workflows/build/gateway-site.xml: ########## @@ -0,0 +1,197 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + +http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +--> +<configuration> + + <property> + <name>gateway.service.alias.impl</name> + <value>org.apache.knox.gateway.services.security.impl.RemoteAliasService</value> + </property> + <property> + <name>gateway.port</name> + <value>8443</value> + <description>The HTTP port for the Gateway.</description> + </property> + + <property> + <name>gateway.path</name> + <value>gateway</value> + <description>The default context path for the gateway.</description> + </property> + + <property> + <name>gateway.gateway.conf.dir</name> + <value>deployments</value> + <description>The directory within GATEWAY_HOME that contains gateway topology files and deployments.</description> + </property> + + <property> + <name>gateway.hadoop.kerberos.secured</name> + <value>false</value> + <description>Boolean flag indicating whether the Hadoop cluster protected by Gateway is secured with Kerberos</description> + </property> + + <property> + <name>java.security.krb5.conf</name> + <value>/etc/knox/conf/krb5.conf</value> + <description>Absolute path to krb5.conf file</description> + </property> + + <property> + <name>java.security.auth.login.config</name> + <value>/etc/knox/conf/krb5JAASLogin.conf</value> + <description>Absolute path to JAAS login config file</description> + </property> + + <property> + <name>sun.security.krb5.debug</name> + <value>false</value> + <description>Boolean flag indicating whether to enable debug messages for krb5 authentication</description> + </property> + + <!-- @since 0.10 Websocket configs --> + <property> + <name>gateway.websocket.feature.enabled</name> + <value>true</value> + <description>Enable/Disable websocket feature.</description> + </property> + + <property> + <name>gateway.scope.cookies.feature.enabled</name> + <value>false</value> + <description>Enable/Disable cookie scoping feature.</description> + </property> + + <property> + <name>gateway.cluster.config.monitor.ambari.enabled</name> + <value>false</value> + <description>Enable/disable Ambari cluster configuration monitoring.</description> + </property> + + <property> + <name>gateway.cluster.config.monitor.ambari.interval</name> + <value>60</value> + <description>The interval (in seconds) for polling Ambari for cluster configuration changes.</description> + </property> Review Comment: Remove Ambari service discovery configs as well as default config that evaluates to `false` anyway. ########## .github/workflows/build/gateway-site.xml: ########## @@ -0,0 +1,197 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + +http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +--> +<configuration> + + <property> + <name>gateway.service.alias.impl</name> + <value>org.apache.knox.gateway.services.security.impl.RemoteAliasService</value> + </property> + <property> + <name>gateway.port</name> + <value>8443</value> + <description>The HTTP port for the Gateway.</description> + </property> + + <property> + <name>gateway.path</name> + <value>gateway</value> + <description>The default context path for the gateway.</description> + </property> + + <property> + <name>gateway.gateway.conf.dir</name> + <value>deployments</value> + <description>The directory within GATEWAY_HOME that contains gateway topology files and deployments.</description> + </property> + + <property> + <name>gateway.hadoop.kerberos.secured</name> + <value>false</value> + <description>Boolean flag indicating whether the Hadoop cluster protected by Gateway is secured with Kerberos</description> + </property> + + <property> + <name>java.security.krb5.conf</name> + <value>/etc/knox/conf/krb5.conf</value> + <description>Absolute path to krb5.conf file</description> + </property> + + <property> + <name>java.security.auth.login.config</name> + <value>/etc/knox/conf/krb5JAASLogin.conf</value> + <description>Absolute path to JAAS login config file</description> + </property> + + <property> + <name>sun.security.krb5.debug</name> + <value>false</value> + <description>Boolean flag indicating whether to enable debug messages for krb5 authentication</description> + </property> Review Comment: Remove Kerberos related config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
