[
https://issues.apache.org/jira/browse/KNOX-3223?focusedWorklogId=996672&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-996672
]
ASF GitHub Bot logged work on KNOX-3223:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Dec/25 12:12
Start Date: 17/Dec/25 12:12
Worklog Time Spent: 10m
Work Description: hanicz opened a new pull request, #1133:
URL: https://github.com/apache/knox/pull/1133
[KNOX-3223](https://issues.apache.org/jira/browse/KNOX-3223) - Remove
redundant SuppressWarnings
## What changes were proposed in this pull request?
- Removed redundant SuppressWarnings
- Replaced deprecated forbiddenapis failOnUnresolvableSignatures with
ignoreSignaturesOfMissingClasses
- Replaced forbidden Subject.getSubject(AccessController.getContext()) with
SubjectUtils.getCurrentSubject() where possible. The AccessController call is
still there is SubjectUtils however its on one place which makesa it easier to
replace with JDK18+.
- Fixed the order of a few asserts in KnoxPam and KnoxLdap tests
## How was this patch tested?
Ran clean verify locally. There are no business logic changes.
Issue Time Tracking
-------------------
Worklog Id: (was: 996672)
Remaining Estimate: 0h
Time Spent: 10m
> Review exclusions from PR 1114
> ------------------------------
>
> Key: KNOX-3223
> URL: https://issues.apache.org/jira/browse/KNOX-3223
> Project: Apache Knox
> Issue Type: Task
> Components: Server
> Affects Versions: 3.0.0
> Reporter: Sandor Molnar
> Assignee: Tamás Hanicz
> Priority: Major
> Fix For: 3.0.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Last week the team switched to JDK 17 with a giant change in [PR
> 1114|https://github.com/apache/knox/pull/1114]. During code reviews we found
> that there are many "suppress" annotations ({{{}@SuppressForbidden{}}} and
> {{{}@SuppressWarnings("PMD"){}}}) were added as well as exclusions and
> ignoredNonTestScopedDependencies for static code analyzer tools.
> We should review them and make a decision if they are ok or fix the root
> cause and enable them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
