moresandeep commented on code in PR #1209:
URL: https://github.com/apache/knox/pull/1209#discussion_r3130037091
##########
gateway-docker/src/main/resources/docker/gateway-entrypoint.sh:
##########
@@ -201,8 +217,9 @@ then
amazon-ca-1:/home/knox/cacrts/AmazonRootCA1.cer
amazon-ca-2:/home/knox/cacrts/AmazonRootCA2.cer
amazon-ca-3:/home/knox/cacrts/AmazonRootCA3.cer
- amazon-ca-4:/home/knox/cacrts/AmazonRootCA4.cer
- letsencrypt-stg-root:/home/knox/cacrts/letsencrypt-stg-root-x1.pem"
Review Comment:
@sneethiraj explained it in his comment on the JIRA, I am copying it here
> There are couple of issues with the PR:
>
> Docker image did not have curl command installed and failing some
commands to get certs from Amazon/LetsEncrypt.
> Lets Encrypt Cert names from Curl command are not matching with the
import statements.
> Keytool does not throw errors on stanard error stream (it is sending
it to stdout). So we have to redirect both stdout and stderr to the /dev/null.
>
> I am attaching couple of patches that fixes these issue. Let me know if
you can review and add it. I have build the docker container and deployed in
k8s env and it works fine.
>
>
[0001-KNOX-3304-added-installation-of-curl-in-the-Docker.patch](https://issues.apache.org/jira/secure/attachment/13081788/13081788_0001-KNOX-3304-added-installation-of-curl-in-the-Docker.patch)
>
[0002-KNOX-3304-fixed-import-of-letsencrupt-root-cert.patch](https://issues.apache.org/jira/secure/attachment/13081789/13081789_0002-KNOX-3304-fixed-import-of-letsencrupt-root-cert.patch)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
