moresandeep commented on code in PR #1208:
URL: https://github.com/apache/knox/pull/1208#discussion_r3130996461
##########
gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/ClientCredentialsResource.java:
##########
@@ -35,11 +40,21 @@
@Path(ClientCredentialsResource.RESOURCE_PATH)
@Singleton
public class ClientCredentialsResource extends PasscodeTokenResourceBase {
- private static final String TYPE = "type";
public static final String RESOURCE_PATH =
"clientid/api/v1/oauth/credentials";
public static final String CLIENT_ID = "client_id";
public static final String CLIENT_SECRET = "client_secret";
private static final String PREFIX = "clientid.";
+ private static final String THIRD_PARTY_APP = "thirdPartyApp";
+
+ private boolean thirdPartyApp;
+
+ @Override
+ @PostConstruct
+ public void init() throws AliasServiceException,
ServiceLifecycleException, KeyLengthException, ServletException {
+ super.init();
+ final String configuredThirdPartyApp =
context.getInitParameter(THIRD_PARTY_APP);
+ thirdPartyApp = configuredThirdPartyApp == null ||
Boolean.parseBoolean(configuredThirdPartyApp);
Review Comment:
I am having a hard time following this, so if configuredThirdPartyApp is
configured as `true` then (configuredThirdPartyApp == null) evaluates to
`false` making thirdPartyApp = false, which is not the intention ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
