[ 
https://issues.apache.org/jira/browse/KNOX-3310?focusedWorklogId=1017624&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1017624
 ]

ASF GitHub Bot logged work on KNOX-3310:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Apr/26 07:35
            Start Date: 28/Apr/26 07:35
    Worklog Time Spent: 10m 
      Work Description: github-actions[bot] commented on PR #1216:
URL: https://github.com/apache/knox/pull/1216#issuecomment-4333235917

   ## Test Results
   21 tests   21 ✅  1s ⏱️
    1 suites   0 💤
    1 files     0 ❌
   
   Results for commit 6ed928cd.
   
   
[test-results]:data:application/gzip;base64,H4sIAC1j8GkC/12Myw6DIBBFf8Ww7kLQUujPNDIMyaQqDY+V6b8XraHa3T3nJmdhjkaM7N7wS8NiplTB5jAk8vOO5UjrJSo8Ygb4M096FdNW4QYaTwJD8GE3Ic+1uO5T8Ct+vY0PuY2PNfDTRKkAk2i1UGCl4dhr7BVIg1w6JzqhXavkzair6TR7fwANIU4+/wAAAA==
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 1017624)
    Time Spent: 20m  (was: 10m)

> Fix redundant and buggy ALIAS_PASSPHRASE assignment in gateway-entrypoint.sh
> ----------------------------------------------------------------------------
>
>                 Key: KNOX-3310
>                 URL: https://issues.apache.org/jira/browse/KNOX-3310
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: docker
>    Affects Versions: 3.0.0
>            Reporter: Sandor Molnar
>            Assignee: Sandor Molnar
>            Priority: Critical
>             Fix For: 3.0.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The importMultipleCerts function in gateway-entrypoint.sh contained a 
> redundant assignment of ALIAS_PASSPHRASE. This assignment was problematic for 
> several reasons:
>    1. *Redundancy:* The variable is already correctly initialized at lines 
> 140–147 with proper fallback logic to MASTER_SECRET.
>    2. *Fragility:* Because set -e is active, the line /bin/cat 
> "${KEYSTORE_PASSWORD_FILE}" would cause the entire entrypoint script to exit 
> immediately if KEYSTORE_PASSWORD_FILE was not provided or was empty.
>    3. *Lack of Fallback:* This specific assignment lacked the logic to use 
> MASTER_SECRET as a fallback, which the global assignment handles correctly.
>  
> Removing this line ensures the function uses the already correctly 
> initialized global variable and prevents unnecessary container crashes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to