lmccay opened a new pull request, #1218:
URL: https://github.com/apache/knox/pull/1218

   (It is very **important** that you created an Apache Knox JIRA for this 
change and that the PR title/commit message includes the Apache Knox JIRA ID!)
   
   [KNOX-3312](https://issues.apache.org/jira/browse/KNOX-3312) - A short 
description of the change
   
   ## What changes were proposed in this pull request?
   
   Current implementation can't get to the grant_type request param.
   
   Unit tests mock out the requests and make it hard to tease this out as an 
issue.
   
   When we know that there is an Authorization header and that it is Basic then 
we need to check whether there is the hardcoded username of token or passcode 
and if not, unwrap the request to check for a grant_type for OAuth 
client_credentials and handle it appropriately.
   
   Current implementation tries to check that but the params are hidden by the 
wrappers.
   
   ## How was this patch tested?
   
   All existing unit and integration tests were run and it was manually tested.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to