[
https://issues.apache.org/jira/browse/KNOX-3340?focusedWorklogId=1024816&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1024816
]
ASF GitHub Bot logged work on KNOX-3340:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jun/26 08:14
Start Date: 12/Jun/26 08:14
Worklog Time Spent: 10m
Work Description: smolnar82 commented on code in PR #1258:
URL: https://github.com/apache/knox/pull/1258#discussion_r3401602462
##########
gateway-server/src/test/java/org/apache/knox/gateway/services/ldap/control/RolesLookupBypassControlDecoratorTest.java:
##########
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.knox.gateway.services.ldap.control;
+
+import static
org.apache.knox.gateway.services.ldap.control.RolesLookupTestConstants.ROLES_LOOKUP_BYPASS_CONTROL_OID;
+import static org.easymock.EasyMock.mock;
+import static org.easymock.EasyMock.replay;
+import static org.junit.Assert.assertArrayEquals;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
+import org.apache.directory.api.asn1.DecoderException;
+import org.apache.directory.api.ldap.codec.api.LdapApiService;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.nio.ByteBuffer;
+
+public class RolesLookupBypassControlDecoratorTest {
+
+ private RolesLookupBypassControl rolesLookupBypassControl;
+ private LdapApiService mockLdapApiService;
+ private RolesLookupBypassControlFactory rolesLookupBypassControlFactory;
+
+ private RolesLookupBypassControlDecorator
rolesLookupBypassControlDecorator;
+
+ @Before
+ public void setUp() throws Exception {
+ mockLdapApiService = mock(LdapApiService.class);
+ replay(mockLdapApiService);
+
+ rolesLookupBypassControl = new
RolesLookupBypassControlImpl(ROLES_LOOKUP_BYPASS_CONTROL_OID);
+ rolesLookupBypassControlFactory = new
RolesLookupBypassControlFactory(mockLdapApiService,
ROLES_LOOKUP_BYPASS_CONTROL_OID);
+
+ rolesLookupBypassControlDecorator = new
RolesLookupBypassControlDecorator(mockLdapApiService, rolesLookupBypassControl,
rolesLookupBypassControlFactory);
+ }
+
+ @Test
+ public void decodeFalseValue() throws Exception {
+ byte[] bytes = new byte[]{0x01, 0x01, 0x00};
+ rolesLookupBypassControlDecorator.decode(bytes);
+
+ assertFalse(rolesLookupBypassControl.isBypassRolesLookup());
+ }
+
+ @Test
+ public void decodeTrueValue() throws Exception {
+ byte[] bytes = new byte[]{0x01, 0x01, (byte) 0xff};
+ rolesLookupBypassControlDecorator.decode(bytes);
+
+ assertTrue(rolesLookupBypassControl.isBypassRolesLookup());
+ }
+
+ @Test(expected = DecoderException.class)
+ public void decodeWrongTag() throws Exception {
+ byte[] bytes = new byte[]{0x02, 0x01, 0x00};
+ rolesLookupBypassControlDecorator.decode(bytes);
+ }
+
+ @Test(expected = DecoderException.class)
+ public void decodeWrongLength() throws Exception {
+ byte[] bytes = new byte[]{0x02, 0x02, 0x00, 0x00};
+ rolesLookupBypassControlDecorator.decode(bytes);
+ }
+
+
+ @Test
+ public void computeLength() {
+ assertEquals("Length must always be 3", 3,
rolesLookupBypassControlDecorator.computeLength());
+ }
+
+ @Test
+ public void encodeTrueValue() throws Exception {
+ rolesLookupBypassControl.setBypassRolesLookup(true);
+ byte[] expectedBytes = new byte[]{0x01, 0x01, (byte) 0xff};
+
+ ByteBuffer byteBuffer = ByteBuffer.allocate(3);
+ ByteBuffer encodedBuffer =
rolesLookupBypassControlDecorator.encode(byteBuffer);
+ // transition from write mode to read mode
+ encodedBuffer.flip();
+ byte[] encodedBytes = new byte[encodedBuffer.remaining()];
+ encodedBuffer.get(encodedBytes);
+ assertArrayEquals(expectedBytes, encodedBytes);
Review Comment:
Maybe creating a new private method (`testEncode(boolean encodeTrue)`) and
call that one from here and from `encodeFalseValue`? The only difference is the
content of `expectedBytes`, but we'd save some lines of duplication.
Issue Time Tracking
-------------------
Worklog Id: (was: 1024816)
Time Spent: 2h 20m (was: 2h 10m)
> Enable KnoxLdapService Role Lookup to return either Roles or Groups
> -------------------------------------------------------------------
>
> Key: KNOX-3340
> URL: https://issues.apache.org/jira/browse/KNOX-3340
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Reporter: David Han
> Assignee: David Han
> Priority: Major
> Fix For: 3.0.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The KnoxLdapService, when configured with role lookup will replace all groups
> in the resulting entries with roles. This Jira provides a mechanism for
> clients to request the underlying groups instead of the roles. E.g., groups
> would be needed for some service to admin/manage the mapping between groups
> and roles.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
