smolnar82 commented on PR #1258:
URL: https://github.com/apache/knox/pull/1258#issuecomment-4691844803
Hi @handavid !
In addition to the above comments, I see that we have unit test failures now:
```
Error: Tests run: 16, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
1.378 s <<< FAILURE! -- in
org.apache.knox.gateway.services.ldap.KnoxLDAPServerManagerTest
Error:
org.apache.knox.gateway.services.ldap.KnoxLDAPServerManagerTest.testStartDontRegistersRolesLookupBypassControl
-- Time elapsed: 0.166 s <<< FAILURE!
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:87)
at org.junit.Assert.assertTrue(Assert.java:42)
at org.junit.Assert.assertFalse(Assert.java:65)
at org.junit.Assert.assertFalse(Assert.java:75)
at
org.apache.knox.gateway.services.ldap.KnoxLDAPServerManagerTest.testStartDontRegistersRolesLookupBypassControl(KnoxLDAPServerManagerTest.java:415)
```
The good news is that this test may go away, because we now have an official
Knox sub-arc under ASF's OID base. See
[KNOX-3346](https://issues.apache.org/jira/browse/KNOX-3346) for details.
Given the new KNOX OID base (`1.3.6.1.4.1.18060.18`), we can drop this
temporary configuration and add our own as part of this PR. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
