[
https://issues.apache.org/jira/browse/KNOX-3350?focusedWorklogId=1025234&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1025234
]
ASF GitHub Bot logged work on KNOX-3350:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jun/26 14:42
Start Date: 15/Jun/26 14:42
Worklog Time Spent: 10m
Work Description: moresandeep commented on code in PR #1264:
URL: https://github.com/apache/knox/pull/1264#discussion_r3414326220
##########
gateway-service-knoxsso/src/main/java/org/apache/knox/gateway/service/knoxsso/WebSSOResource.java:
##########
@@ -224,6 +228,8 @@ private void handleCookieSetup() {
}
final String configuredTokenType =
context.getInitParameter(SSO_COOKIE_TOKEN_TYPE_PARAM);
tokenType = StringUtils.isBlank(configuredTokenType) ?
JOSEObjectType.JWT.getType() : configuredTokenType;
+
+ includeGroups =
Boolean.parseBoolean(context.getInitParameter(SSO_COOKIE_INCLUDE_GROUPS_PARAM));
Review Comment:
Cool, I explicitly declare the default value and add it to be in-line with
the pattern elsewhere in the code and also helps me in reading in the future. I
am okay with this, thanks!
Issue Time Tracking
-------------------
Worklog Id: (was: 1025234)
Time Spent: 1h (was: 50m)
> Allow group membership information to be included in issued KNOXSSO cookie
> --------------------------------------------------------------------------
>
> Key: KNOX-3350
> URL: https://issues.apache.org/jira/browse/KNOX-3350
> Project: Apache Knox
> Issue Type: Improvement
> Components: KnoxSSO
> Affects Versions: 2.0.0, 2.1.0
> Reporter: Sandor Molnar
> Priority: Major
> Fix For: 3.0.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> KNOX-2731 added the ability to include group information (if available), in
> the generated JWTs by the {{KNOXTOKEN}} service.
> It'd be beneficial to decorate the `hadoop-jwt` SSO cookie with groups as
> well (in case if's configured).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
