potiuk commented on PR #1293: URL: https://github.com/apache/knox/pull/1293#issuecomment-4882207732
Quick note on the CI: the red was `apache-rat` flagging the three added `.md` files. I've just pushed a commit adding the full Apache License v2.0 header (as an HTML comment) to each, which resolves it under this repo's current `apache-rat` **0.13** — so the PR should go green as-is. One alternative worth flagging: `apache-rat-plugin.version` here is pinned to **0.13** (~2015). Newer RAT (**0.16.1**) recognises the SPDX identifier and has a decade of format/bugfix improvements. If the PMC prefers, I'm happy to **swap the header commit for a one-line bump** of that property (`0.13` → `0.16.1`) instead — whichever you'd rather carry. Just say the word and I'll include it here. No strong preference from our side; the header fix already gets you green, so the bump is purely optional cleanup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
