[
https://issues.apache.org/jira/browse/KNOX-3359?focusedWorklogId=1028510&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1028510
]
ASF GitHub Bot logged work on KNOX-3359:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jul/26 18:14
Start Date: 07/Jul/26 18:14
Worklog Time Spent: 10m
Work Description: moresandeep commented on code in PR #1291:
URL: https://github.com/apache/knox/pull/1291#discussion_r3538694668
##########
gateway-server/src/main/java/org/apache/knox/gateway/config/impl/GatewayConfigImpl.java:
##########
@@ -818,6 +818,45 @@ public String getHttpClientTruststorePasswordAlias() {
return get(HTTP_CLIENT_TRUSTSTORE_PASSWORD_ALIAS,
DEFAULT_HTTP_CLIENT_TRUSTSTORE_PASSWORD_ALIAS);
}
+ @Override
+ public String getHttpClientKeystorePath() {
+ return get(HTTP_CLIENT_KEYSTORE_PATH);
+ }
+
+ @Override
+ public String getHttpClientKeystoreType() {
+ return get(HTTP_CLIENT_KEYSTORE_TYPE, DEFAULT_HTTP_CLIENT_KEYSTORE_TYPE);
+ }
+
+ @Override
+ public String getHttpClientKeystorePasswordAlias() {
+ return get(HTTP_CLIENT_KEYSTORE_PASSWORD_ALIAS,
DEFAULT_HTTP_CLIENT_KEYSTORE_PASSWORD_ALIAS);
+ }
+
+ @Override
+ public String getHttpClientKeyAlias() {
+ return get(HTTP_CLIENT_KEY_ALIAS, DEFAULT_HTTP_CLIENT_KEY_ALIAS);
+ }
+
+ @Override
+ public String getHttpClientKeyPassphraseAlias() {
+ return get(HTTP_CLIENT_KEY_PASSPHRASE_ALIAS,
DEFAULT_HTTP_CLIENT_KEY_PASSPHRASE_ALIAS);
+ }
+
+ @Override
+ public boolean isSingleEkuEnabled() {
+ return getBoolean(TLS_SINGLE_EKU_ENABLED, DEFAULT_TLS_SINGLE_EKU_ENABLED);
+ }
+
+ @Override
+ public boolean isHttpClientTwoWaySslEnabled() {
+ String configured = get(HTTP_CLIENT_TWO_WAY_SSL_ENABLED);
+ if (configured != null) {
+ return Boolean.parseBoolean(configured);
Review Comment:
Yeah, this method intends to fall back to `isSingleEkuEnabled()` this is
because, for single EKU feature to work two-way-ssl is required as a result if
two-way-ssl is not configured we default it to `isSingleEkuEnabled()`.
So, if someone turned on `isSingleEkuEnabled()` then they not need to
specifically turn on two-way-ssl as those go hand in hand.
Issue Time Tracking
-------------------
Worklog Id: (was: 1028510)
Time Spent: 40m (was: 0.5h)
> Support Single-Purpose EKU Certificates
> ---------------------------------------
>
> Key: KNOX-3359
> URL: https://issues.apache.org/jira/browse/KNOX-3359
> Project: Apache Knox
> Issue Type: New Feature
> Components: Server
> Reporter: Sandeep More
> Assignee: Sandeep More
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> h1. Background
> Knox currently supports a single certificate per host. This certificate
> carries both the serverAuth and clientAuth Extended Key Usages (EKUs),
> meaning the same key and certificate is used whether the service running on
> the host is acting as a TLS server or as a client in a mutual-TLS (mTLS)
> handshake.
>
> Industry standards and public CAs (like DigiCert) are sunsetting multi-use
> certificates, making Knox's current requirement for dual serverAuth and
> clientAuth EKUs difficult to manage.
> h1. Overview:
> Knox will need separate keystores and truststores for client authentication
> and server authentication.
> # Keystores:
> *
> -- Knox to assert its identity as a server
> -- Knox to assert its identity as a client (to downstream services)
> 2.Truststores:
> *
> -- Clients asserting identity to Knox
> -- Servers asserting identity to Knox
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
