hsheinblatt commented on code in PR #1322:
URL: https://github.com/apache/knox/pull/1322#discussion_r3643723971
##########
gateway-server/src/test/java/org/apache/knox/gateway/services/knoxidf/trustedoidcissuer/JdbcTrustedOidcIssuerServiceTest.java:
##########
@@ -234,13 +234,9 @@ public void testMaxTrustedIssuers() throws
ServiceLifecycleException {
limitedService.register(issuer("https://b.example.com";, false));
assertEquals("Second registration must succeed", 2,
limitedService.list().size());
- try {
Review Comment:
Generally I prefer to use the try/catch with fail rather than an expected
exception in any test that makes more than one call. In this case there are
several calls to limitedService. With the general expected exception, you don't
know where the exception came from, it could have happened well before you
intend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
