bonampak commented on code in PR #1181:
URL: https://github.com/apache/knox/pull/1181#discussion_r3674457790
##########
gateway-shell/src/main/java/org/apache/knox/gateway/shell/commands/AbstractKnoxShellCommand.java:
##########
@@ -74,8 +94,70 @@ protected String
getBindingVariableNameForResultingTable(List<String> args) {
}
protected CredentialCollector login() throws CredentialCollectionException {
- KnoxLoginDialog dlg = new KnoxLoginDialog();
- dlg.collect();
- return dlg;
+ LineReader reader = LineReaderBuilder.builder()
Review Comment:
You're right, it's not necessary. Reverted back to KnoxLoginDialog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
