smolnar82 commented on PR #1342: URL: https://github.com/apache/knox/pull/1342#issuecomment-5264314729
> Some RFC 8693 token exchange related constants were moved from TokenExchangeHandler to JWTFederationFilter so that the tests outside the package, namely JWTFederationFilterTokenExchangeTest, can read the values. I think this is the wrong approach: those constants should be in `TokenExchangeHandler` and the test should have been added in the same package (now everything is in the `...filter` package, but the test is outside. I'll file a follow-up JIRA to resolve this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
