[ 
https://issues.apache.org/jira/browse/KNOX-3433?focusedWorklogId=1039443&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1039443
 ]

ASF GitHub Bot logged work on KNOX-3433:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Sep/26 13:41
            Start Date: 03/Sep/26 13:41
    Worklog Time Spent: 10m 
      Work Description: smolnar82 opened a new pull request, #1375:
URL: https://github.com/apache/knox/pull/1375

   [KNOX-3433](https://issues.apache.org/jira/browse/KNOX-3433) - Set 
issued_token_type in KnoxIDF token responses
   
   ## What changes were proposed in this pull request?
   
   RFC 8693 §2.2.1 requires the token response to include `issued_token_type`; 
KnoxIDF didn't set it.
   
   KnoxIDF always mints a JWT, so `TokenResource.buildResponseMap` now sets 
`issued_token_type = urn:ietf:params:oauth:token-type:jwt` on all grants 
(authorization_code, refresh_token, client_credentials).
   
   
   ## How was this patch tested?
   
   Docker Compose integration suite: all 77 tests pass, including 
`test_knoxidf`:
   ```
     tests-1  | platform linux 

Issue Time Tracking
-------------------

            Worklog Id:     (was: 1039443)
    Remaining Estimate: 0h
            Time Spent: 10m

> knoxidf token exchange response must include issued_token_type
> --------------------------------------------------------------
>
>                 Key: KNOX-3433
>                 URL: https://issues.apache.org/jira/browse/KNOX-3433
>             Project: Apache Knox
>          Issue Type: Task
>          Components: JWT
>            Reporter: Harrison Sheinblatt
>            Assignee: Sandor Molnar
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> RFC 8693 §2.2.1 requires the response include issued_token_type
> It's not set now by knoxidf.
> The correct value to set is "urn:ietf:params:oauth:token-type:jwt". While 
> access_token may be OK in some circumstances, since we're returning a jwt 
> that is meant to be used as a jwt for possible future exchanges and authz, so 
> the client might parse it to get, for example, group claims, jwt is correct 
> here.
> Note that OAuthResource does set the field in the response, but hardcodes it 
> to access_token and has different logic than the base knoxtoken 
> TokenResource, so it's unclear we want to inherit from that and refactor it 
> to allow the jwt value. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to