[ 
https://issues.apache.org/jira/browse/KNOX-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18113347#comment-18113347
 ] 

Tamás Marcinkovics commented on KNOX-2900:
------------------------------------------

There are a couple of issues before we can re-enable the service filter in CM 
discovery.
1) if a service that is part of discovery has an invalid config and is 
restarted, PollingConfigurationAnalyzer will trigger an autodiscovery because 
of the restart event. So we should 
prevent rediscovery of services that remained in an invalid config state. 

2) PCA does not use the same workflow as CM Service Discovery. It does not 
build ServiceModels and cannot observe if a service configuration is valid or 
not. It should use the same workflow and compare the discovery output with the 
one in ClusterConfigurationCache.
3) If the service filter is enabled, each discovery triggered by a topology 
descriptor change overwrites the global ClusterConfigurationCache with its 
discovery result. We should merge the results to the cache (.ver file) instead 
of overwriting it, as the cache would only contain service types declared in 
the latest topology that was discovered.

4) Currently the 
gateway.cloudera.manager.service.discovery.excluded.service.types 
is only used during CM autodiscovery, not in PCA. We should treat start and 
scale events for excluded service types as non-relevant.
5) Same for gateway.cloudera.manager.service.discovery.excluded.role.types: PCA 
should ignore scale events for role types discovery doesn't collect.

If these are implemented, we can re-enable the service filter in CM discovery.

> KNOX-2899 followup - reenable service based discovery filter
> ------------------------------------------------------------
>
>                 Key: KNOX-2900
>                 URL: https://issues.apache.org/jira/browse/KNOX-2900
>             Project: Apache Knox
>          Issue Type: Task
>            Reporter: Attila Magyar
>            Priority: Major
>
> In KNOX-2899 the service based discovery filter was temporary disabled 
> because it interferes with the polling configurator analyzer. 
> * Either a permanent fix is needed that works well with the polling config 
> analyizer
> * Or the filter should be permanently removed, if the performance gain would 
> be negligible
> cc: [~smolnar]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to